rcv: Add RvTipoVenta enum to represent "Tipo de Venta" in RCV #852
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new enum RvTipoVenta to represent "Tipo de Venta" (Sales Type) values in the RCV domain, extending the constants module with two sales type options.
- Adds
RvTipoVentaenum with two members:DEL_GIROandNO_CORRESPONDE_INCLUIR - Includes comprehensive test coverage for the new enum
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cl_sii/rcv/constants.py | Adds the new RvTipoVenta enum with two sales type constants |
| src/tests/test_rcv_constants.py | Adds test class with coverage for enum members and value types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #852 +/- ##
===========================================
+ Coverage 87.84% 87.87% +0.03%
===========================================
Files 38 38
Lines 3193 3201 +8
Branches 323 323
===========================================
+ Hits 2805 2813 +8
Misses 249 249
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svillegas-cdd
force-pushed
the
task/sc-16108-add-rcv-tipo-venta
branch
from
6962b32 to
e59f095
Compare
|
Ref: https://app.shortcut.com/cordada/story/16108/